From b79741c90ffffac6fb24783b38c5b507316cbcc8 Mon Sep 17 00:00:00 2001 From: Muhammad Rifqi Priyo Susanto Date: Sat, 28 Sep 2019 01:13:08 +0700 Subject: All settings: Fix missing flags checkbox caused by 'possible flags' order (#8997) Previously, the 'rivers' checkbox was missing for mgcarpathian, caused by the 'possible flags' order: 'caverns,nocaverns,rivers,norivers'. Also reorder mgcarpathian 'possible flags', but only for consistency. --- builtin/mainmenu/dlg_settings_advanced.lua | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'builtin/mainmenu') diff --git a/builtin/mainmenu/dlg_settings_advanced.lua b/builtin/mainmenu/dlg_settings_advanced.lua index 6d40ace35..24b71d957 100644 --- a/builtin/mainmenu/dlg_settings_advanced.lua +++ b/builtin/mainmenu/dlg_settings_advanced.lua @@ -688,14 +688,16 @@ local function create_change_setting_formspec(dialogdata) height = height - 1 local fields = {} -- To build formspec - for i, name in ipairs(setting.possible) do + local j = 1 + for _, name in ipairs(setting.possible) do if name:sub(1, 2) ~= "no" then local x = 0.5 - local y = height + i / 2 - 0.75 - if i - 1 >= flags_count / 2 then -- 2nd column + local y = height + j / 2 - 0.75 + if j - 1 >= flags_count / 2 then -- 2nd column x = 5 y = y - max_height end + j = j + 1; local checkbox_name = "cb_" .. name local is_enabled = flags[name] == true -- to get false if nil checkboxes[checkbox_name] = is_enabled -- cgit v1.2.3