diff options
author | Christian Engelmayer <cengelma@gmx.at> | 2014-04-21 20:46:40 +0200 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-04-28 18:21:18 +0800 |
commit | 0c41fd0804d196cbc86fb4ea4859d2b27a4ade11 (patch) | |
tree | bf1014b0592e2888e35b5001b36909fc911f4517 | |
parent | e5f8ed38c207b37720a733b3d73f8f5a1c8f41ab (diff) | |
download | linux-crypto-0c41fd0804d196cbc86fb4ea4859d2b27a4ade11.tar.gz linux-crypto-0c41fd0804d196cbc86fb4ea4859d2b27a4ade11.zip |
crypto: tcrypt - Fix potential leak in test_aead_speed() if crypto_alloc_aead() fails
Fix a potential memory leak in the error handling of test_aead_speed(). In case
crypto_alloc_aead() fails, the function returns without going through the
centralized cleanup path. Reported by Coverity - CID 1163870.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Marek Vasut <marex@denx.de>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to '')
-rw-r--r-- | crypto/tcrypt.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 1856d7ff..18491552 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -313,7 +313,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec, if (IS_ERR(tfm)) { pr_err("alg: aead: Failed to load transform for %s: %ld\n", algo, PTR_ERR(tfm)); - return; + goto out_notfm; } req = aead_request_alloc(tfm, GFP_KERNEL); @@ -391,6 +391,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec, out: crypto_free_aead(tfm); +out_notfm: kfree(sg); out_nosg: testmgr_free_buf(xoutbuf); |