diff options
author | Jonathan Corbet <corbet@lwn.net> | 2011-11-02 09:15:16 +1100 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2011-11-02 09:15:16 +1100 |
commit | 1cedd5203a4c850917011de0eeb6787ca643840e (patch) | |
tree | 20cdde4c2230ce0f1cfcb1331abf3c6596050aad | |
parent | b220aa1680ced151bea05d54497bf4b7a76dc7d3 (diff) | |
download | linux-crypto-1cedd5203a4c850917011de0eeb6787ca643840e.tar.gz linux-crypto-1cedd5203a4c850917011de0eeb6787ca643840e.zip |
crypto: user - Fix rwsem leak in crypto_user
The list_empty case in crypto_alg_match() will return without calling
up_read() on crypto_alg_sem. We could do the "goto out" routine, but the
function will clearly do the right thing with that test simply removed.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to '')
-rw-r--r-- | crypto/crypto_user.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index 2abca780..0605a2bb 100644 --- a/crypto/crypto_user.c +++ b/crypto/crypto_user.c @@ -44,9 +44,6 @@ static struct crypto_alg *crypto_alg_match(struct crypto_user_alg *p, int exact) down_read(&crypto_alg_sem); - if (list_empty(&crypto_alg_list)) - return NULL; - list_for_each_entry(q, &crypto_alg_list, cra_list) { int match = 0; |