summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 14:34:54 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-13 08:43:11 +0100
commit0cbf0de636a1eabe2536b0d367b0d0dde6baa87f (patch)
treea5165a6fa92869eb6569b4daa39e2aaec4911d84
parent7cc3ebe6a468000918cd090624a6bb974f97609e (diff)
downloadlinux-crypto-0cbf0de636a1eabe2536b0d367b0d0dde6baa87f.tar.gz
linux-crypto-0cbf0de636a1eabe2536b0d367b0d0dde6baa87f.zip
crypto: user - fix memory leak in crypto_reportstat
commit 51a65c657e5868cb31f6746beefda1f8c444edba upstream. In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is leaked if crypto_reportstat_alg() fails. Required release for skb is added. Fixes: 0115ab23b941 ("crypto: user - Implement a generic crypto statistics") Cc: <stable@vger.kernel.org> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--crypto/crypto_user_stat.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
index 8bad8841..1be95432 100644
--- a/crypto/crypto_user_stat.c
+++ b/crypto/crypto_user_stat.c
@@ -328,8 +328,10 @@ int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}