diff options
| author | Eric Biggers <ebiggers@google.com> | 2019-01-08 22:12:41 -0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-01-10 21:37:32 +0800 |
| commit | bc2a1ca9b6b0c50decebcbb4c6b4160cf81eed93 (patch) | |
| tree | ad35f7c066ef1e52febbbfc0fc62fe9623cc4e00 | |
| parent | 4155904c16770af1d62b86aafef09003ae316092 (diff) | |
| download | linux-crypto-bc2a1ca9b6b0c50decebcbb4c6b4160cf81eed93.tar.gz linux-crypto-bc2a1ca9b6b0c50decebcbb4c6b4160cf81eed93.zip | |
crypto: sm3 - fix undefined shift by >= width of value
sm3_compress() calls rol32() with shift >= 32, which causes undefined
behavior. This is easily detected by enabling CONFIG_UBSAN.
Explicitly AND with 31 to make the behavior well defined.
Fixes: 04e742a6ad06 ("crypto: sm3 - add OSCCA SM3 secure hash")
Cc: <stable@vger.kernel.org> # v4.15+
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | crypto/sm3_generic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/sm3_generic.c b/crypto/sm3_generic.c index 9a5c60f0..c0cf87ae 100644 --- a/crypto/sm3_generic.c +++ b/crypto/sm3_generic.c @@ -100,7 +100,7 @@ static void sm3_compress(u32 *w, u32 *wt, u32 *m) for (i = 0; i <= 63; i++) { - ss1 = rol32((rol32(a, 12) + e + rol32(t(i), i)), 7); + ss1 = rol32((rol32(a, 12) + e + rol32(t(i), i & 31)), 7); ss2 = ss1 ^ rol32(a, 12); |