diff options
| author | David S. Miller <davem@davemloft.net> | 2012-04-01 20:19:05 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-02 04:33:42 -0400 |
| commit | 783831895db4ef1d654fb1998a3006502f394d97 (patch) | |
| tree | ccb88f2e4ba02ecb37e89ba9457cdec577802747 /crypto/ahash.c | |
| parent | bb5197831a43146cd4687853edbc0faec2bb9187 (diff) | |
| download | linux-crypto-783831895db4ef1d654fb1998a3006502f394d97.tar.gz linux-crypto-783831895db4ef1d654fb1998a3006502f394d97.zip | |
crypto: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/ahash.c')
| -rw-r--r-- | crypto/ahash.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crypto/ahash.c b/crypto/ahash.c index 33bc9b62..3887856c 100644 --- a/crypto/ahash.c +++ b/crypto/ahash.c @@ -409,9 +409,9 @@ static int crypto_ahash_report(struct sk_buff *skb, struct crypto_alg *alg) rhash.blocksize = alg->cra_blocksize; rhash.digestsize = __crypto_hash_alg_common(alg)->digestsize; - NLA_PUT(skb, CRYPTOCFGA_REPORT_HASH, - sizeof(struct crypto_report_hash), &rhash); - + if (nla_put(skb, CRYPTOCFGA_REPORT_HASH, + sizeof(struct crypto_report_hash), &rhash)) + goto nla_put_failure; return 0; nla_put_failure: |