diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-10 19:55:45 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-10 19:55:45 -0800 |
| commit | 13a7af2378dfab31fd00e73f1986e92b60e09377 (patch) | |
| tree | 962383f0b460f77f3f40909870186eda06aad39d /crypto/algif_skcipher.c | |
| parent | 09079c19a2d0e249a69ab1e54925e56c4950cca1 (diff) | |
| download | linux-crypto-13a7af2378dfab31fd00e73f1986e92b60e09377.tar.gz linux-crypto-13a7af2378dfab31fd00e73f1986e92b60e09377.zip | |
crypto: fix af_alg_make_sg() conversion to iov_iter
Commit a72af7c1bd53 ("crypto: switch af_alg_make_sg() to iov_iter")
broke af_alg_make_sg() and skcipher_recvmsg() in the process of moving
them to the iov_iter interfaces. The 'npages' calculation in the formar
calculated the number of *bytes* in the pages, and in the latter case
the conversion didn't re-read the value of 'ctx->used' after waiting for
it to become non-zero.
This reverts to the original code for both these cases.
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'crypto/algif_skcipher.c')
| -rw-r--r-- | crypto/algif_skcipher.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c index 37110fd6..6fc12c3f 100644 --- a/crypto/algif_skcipher.c +++ b/crypto/algif_skcipher.c @@ -439,14 +439,13 @@ static int skcipher_recvmsg(struct kiocb *unused, struct socket *sock, while (!sg->length) sg++; - used = ctx->used; - if (!used) { + if (!ctx->used) { err = skcipher_wait_for_data(sk, flags); if (err) goto unlock; } - used = min_t(unsigned long, used, iov_iter_count(&msg->msg_iter)); + used = min_t(unsigned long, ctx->used, iov_iter_count(&msg->msg_iter)); used = af_alg_make_sg(&ctx->rsgl, &msg->msg_iter, used); err = used; |