diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2019-12-07 22:15:15 +0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-12-11 16:48:38 +0800 |
| commit | bc1d8cb6169a2deb7dbcad8ac6ed8ade1bc2bb05 (patch) | |
| tree | 05d67f852eecd755f29595aeabac40223b4e9624 /crypto/api.c | |
| parent | bc39d9486351deb0881a382c6c2d52b73467d304 (diff) | |
| download | linux-crypto-bc1d8cb6169a2deb7dbcad8ac6ed8ade1bc2bb05.tar.gz linux-crypto-bc1d8cb6169a2deb7dbcad8ac6ed8ade1bc2bb05.zip | |
crypto: api - Fix race condition in crypto_spawn_alg
The function crypto_spawn_alg is racy because it drops the lock
before shooting the dying algorithm. The algorithm could disappear
altogether before we shoot it.
This patch fixes it by moving the shooting into the locked section.
Fixes: 525ed3dcb430 ("[CRYPTO] api: Added spawns")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/api.c')
| -rw-r--r-- | crypto/api.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crypto/api.c b/crypto/api.c index ef96142c..676d54ff 100644 --- a/crypto/api.c +++ b/crypto/api.c @@ -331,13 +331,12 @@ static unsigned int crypto_ctxsize(struct crypto_alg *alg, u32 type, u32 mask) return len; } -void crypto_shoot_alg(struct crypto_alg *alg) +static void crypto_shoot_alg(struct crypto_alg *alg) { down_write(&crypto_alg_sem); alg->cra_flags |= CRYPTO_ALG_DYING; up_write(&crypto_alg_sem); } -EXPORT_SYMBOL_GPL(crypto_shoot_alg); struct crypto_tfm *__crypto_alloc_tfm(struct crypto_alg *alg, u32 type, u32 mask) |