diff options
| author | Mat Martineau <mathew.j.martineau@linux.intel.com> | 2016-07-18 00:10:55 +0100 |
|---|---|---|
| committer | James Morris <james.l.morris@oracle.com> | 2016-07-18 12:19:47 +1000 |
| commit | 707bbd9bf2d2a811bddcaa582b998d110fc371f4 (patch) | |
| tree | 671e71fb2ff0d881cdf302f8c69bfc7fa4ce5f4a /crypto/asymmetric_keys/restrict.c | |
| parent | ea10f5e0c062b9511ff3ec99cc9fe9e804595f3a (diff) | |
| download | linux-crypto-707bbd9bf2d2a811bddcaa582b998d110fc371f4.tar.gz linux-crypto-707bbd9bf2d2a811bddcaa582b998d110fc371f4.zip | |
KEYS: Fix for erroneous trust of incorrectly signed X.509 certs
Arbitrary X.509 certificates without authority key identifiers (AKIs)
can be added to "trusted" keyrings, including IMA or EVM certs loaded
from the filesystem. Signature verification is currently bypassed for
certs without AKIs.
Trusted keys were recently refactored, and this bug is not present in
4.6.
restrict_link_by_signature should return -ENOKEY (no matching parent
certificate found) if the certificate being evaluated has no AKIs,
instead of bypassing signature checks and returning 0 (new certificate
accepted).
Reported-by: Petko Manolov <petkan@mip-labs.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Diffstat (limited to 'crypto/asymmetric_keys/restrict.c')
| -rw-r--r-- | crypto/asymmetric_keys/restrict.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/asymmetric_keys/restrict.c b/crypto/asymmetric_keys/restrict.c index ac4bddf6..19d1afb9 100644 --- a/crypto/asymmetric_keys/restrict.c +++ b/crypto/asymmetric_keys/restrict.c @@ -87,7 +87,7 @@ int restrict_link_by_signature(struct key *trust_keyring, sig = payload->data[asym_auth]; if (!sig->auth_ids[0] && !sig->auth_ids[1]) - return 0; + return -ENOKEY; if (ca_keyid && !asymmetric_key_id_partial(sig->auth_ids[1], ca_keyid)) return -EPERM; |