diff options
author | Eric Biggers <ebiggers@google.com> | 2019-03-31 13:04:12 -0700 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-04-08 14:42:54 +0800 |
commit | 248a4a0238f378bff1825255a0c0f2a4d3d037d9 (patch) | |
tree | 8aefa3e87b019a09d2b47641aa5d242b27763699 /crypto/chacha20poly1305.c | |
parent | b2ca7cee9efa535c91058202d5ae6a938cca416b (diff) | |
download | linux-crypto-248a4a0238f378bff1825255a0c0f2a4d3d037d9.tar.gz linux-crypto-248a4a0238f378bff1825255a0c0f2a4d3d037d9.zip |
crypto: crct10dif-generic - fix use via crypto_shash_digest()
The ->digest() method of crct10dif-generic reads the current CRC value
from the shash_desc context. But this value is uninitialized, causing
crypto_shash_digest() to compute the wrong result. Fix it.
Probably this wasn't noticed before because lib/crc-t10dif.c only uses
crypto_shash_update(), not crypto_shash_digest(). Likewise,
crypto_shash_digest() is not yet tested by the crypto self-tests because
those only test the ahash API which only uses shash init/update/final.
This bug was detected by my patches that improve testmgr to fuzz
algorithms against their generic implementation.
Fixes: 24e7cd682f89 ("crypto: crct10dif - Wrap crc_t10dif function all to use crypto transform framework")
Cc: <stable@vger.kernel.org> # v3.11+
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/chacha20poly1305.c')
0 files changed, 0 insertions, 0 deletions