summaryrefslogtreecommitdiff
path: root/crypto/crypto_user_base.c
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 14:29:16 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-13 08:43:10 +0100
commit7cc3ebe6a468000918cd090624a6bb974f97609e (patch)
tree8543284cf020276547f4a4a268ba2e199bba1cb4 /crypto/crypto_user_base.c
parent7214ec30b767cb3d0411523e030cd3041707435e (diff)
downloadlinux-crypto-7cc3ebe6a468000918cd090624a6bb974f97609e.tar.gz
linux-crypto-7cc3ebe6a468000918cd090624a6bb974f97609e.zip
crypto: user - fix memory leak in crypto_report
commit f1a5778c0239e65288ffb87842d8173b45f719fd upstream. In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails. Fixes: 2da2418a8b84 ("crypto: Add userspace configuration API") Cc: <stable@vger.kernel.org> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '')
-rw-r--r--crypto/crypto_user_base.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user_base.c b/crypto/crypto_user_base.c
index 910e0b46..b785c476 100644
--- a/crypto/crypto_user_base.c
+++ b/crypto/crypto_user_base.c
@@ -213,8 +213,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}