diff options
| author | Eric Biggers <ebiggers@google.com> | 2020-01-02 19:58:45 -0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2020-01-09 11:30:54 +0800 |
| commit | 4421083bc0f01da380967ffab5e017f3d641af9d (patch) | |
| tree | 0df06391a5d069013de74c80544d9351d2fecacb /crypto/ctr.c | |
| parent | 9e84b19eaf25c6f394d08323ed779e98eb9c029d (diff) | |
| download | linux-crypto-4421083bc0f01da380967ffab5e017f3d641af9d.tar.gz linux-crypto-4421083bc0f01da380967ffab5e017f3d641af9d.zip | |
crypto: skcipher - pass instance to crypto_grab_skcipher()
Initializing a crypto_skcipher_spawn currently requires:
1. Set spawn->base.inst to point to the instance.
2. Call crypto_grab_skcipher().
But there's no reason for these steps to be separate, and in fact this
unneeded complication has caused at least one bug, the one fixed by
commit 4155904c1677 ("crypto: adiantum - initialize crypto_spawn::inst")
So just make crypto_grab_skcipher() take the instance as an argument.
To keep the function calls from getting too unwieldy due to this extra
argument, also introduce a 'mask' variable into the affected places
which weren't already using one.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/ctr.c')
| -rw-r--r-- | crypto/ctr.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crypto/ctr.c b/crypto/ctr.c index b63b19de..a8feab62 100644 --- a/crypto/ctr.c +++ b/crypto/ctr.c @@ -286,8 +286,8 @@ static int crypto_rfc3686_create(struct crypto_template *tmpl, spawn = skcipher_instance_ctx(inst); - crypto_set_skcipher_spawn(spawn, skcipher_crypto_instance(inst)); - err = crypto_grab_skcipher(spawn, cipher_name, 0, mask); + err = crypto_grab_skcipher(spawn, skcipher_crypto_instance(inst), + cipher_name, 0, mask); if (err) goto err_free_inst; |