diff options
author | David Howells <dhowells@redhat.com> | 2016-02-24 14:37:15 +0000 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2016-02-29 14:29:40 +0000 |
commit | 4852611f16827af0b03e10306b91e20de8520123 (patch) | |
tree | 8586d77419929f7d363209f4c456133699dab43b /crypto/cts.c | |
parent | 71fbd874bdaac5f138d3d8f29e4b8e585609cbc3 (diff) | |
download | linux-crypto-4852611f16827af0b03e10306b91e20de8520123.tar.gz linux-crypto-4852611f16827af0b03e10306b91e20de8520123.zip |
X.509: Fix leap year handling again
There are still a couple of minor issues in the X.509 leap year handling:
(1) To avoid doing a modulus-by-400 in addition to a modulus-by-100 when
determining whether the year is a leap year or not, I divided the year
by 100 after doing the modulus-by-100, thereby letting the compiler do
one instruction for both, and then did a modulus-by-4.
Unfortunately, I then passed the now-modified year value to mktime64()
to construct a time value.
Since this isn't a fast path and since mktime64() does a bunch of
divisions, just condense down to "% 400". It's also easier to read.
(2) The default month length for any February where the year doesn't
divide by four exactly is obtained from the month_length[] array where
the value is 29, not 28.
This is fixed by altering the table.
Reported-by: Rudolf Polzer <rpolzer@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
cc: stable@vger.kernel.org
Diffstat (limited to 'crypto/cts.c')
0 files changed, 0 insertions, 0 deletions