diff options
| author | Eric Biggers <ebiggers@google.com> | 2022-07-25 11:36:35 -0700 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2022-08-19 18:39:34 +0800 |
| commit | f772c92905cf45b87e6b9f7f06287cea90e2727d (patch) | |
| tree | b826f5b05dcc1df1b9c7050626775f44799e62b4 /crypto/drbg.c | |
| parent | ee2e19d4945cbb18158bd8d784142c000f537ae4 (diff) | |
| download | linux-crypto-f772c92905cf45b87e6b9f7f06287cea90e2727d.tar.gz linux-crypto-f772c92905cf45b87e6b9f7f06287cea90e2727d.zip | |
crypto: lib - move __crypto_xor into utils
CRYPTO_LIB_CHACHA depends on CRYPTO for __crypto_xor, defined in
crypto/algapi.c. This is a layering violation because the dependencies
should only go in the other direction (crypto/ => lib/crypto/). Also
the correct dependency would be CRYPTO_ALGAPI, not CRYPTO. Fix this by
moving __crypto_xor into the utils module in lib/crypto/.
Note that CRYPTO_LIB_CHACHA_GENERIC selected XOR_BLOCKS, which is
unrelated and unnecessary. It was perhaps thought that XOR_BLOCKS was
needed for __crypto_xor, but that's not the case.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions