diff options
author | David S. Miller <davem@davemloft.net> | 2012-04-01 20:19:05 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-04-02 04:33:42 -0400 |
commit | 783831895db4ef1d654fb1998a3006502f394d97 (patch) | |
tree | ccb88f2e4ba02ecb37e89ba9457cdec577802747 /crypto/pcompress.c | |
parent | bb5197831a43146cd4687853edbc0faec2bb9187 (diff) | |
download | linux-crypto-783831895db4ef1d654fb1998a3006502f394d97.tar.gz linux-crypto-783831895db4ef1d654fb1998a3006502f394d97.zip |
crypto: Stop using NLA_PUT*().
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/pcompress.c')
-rw-r--r-- | crypto/pcompress.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crypto/pcompress.c b/crypto/pcompress.c index 2e458e54..04e083ff 100644 --- a/crypto/pcompress.c +++ b/crypto/pcompress.c @@ -55,9 +55,9 @@ static int crypto_pcomp_report(struct sk_buff *skb, struct crypto_alg *alg) snprintf(rpcomp.type, CRYPTO_MAX_ALG_NAME, "%s", "pcomp"); - NLA_PUT(skb, CRYPTOCFGA_REPORT_COMPRESS, - sizeof(struct crypto_report_comp), &rpcomp); - + if (nla_put(skb, CRYPTOCFGA_REPORT_COMPRESS, + sizeof(struct crypto_report_comp), &rpcomp)) + goto nla_put_failure; return 0; nla_put_failure: |