diff options
| author | Eric Biggers <ebiggers@google.com> | 2022-01-18 16:13:05 -0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2022-01-31 11:21:44 +1100 |
| commit | 93793f8fa3ab9cf3655a339357c295f870aa9622 (patch) | |
| tree | 66b7d5a0f4e027e067939174ff33435b275592d0 /crypto/rsa-pkcs1pad.c | |
| parent | 0d0aac0ddfa341f8c995f903070915f1aa868d61 (diff) | |
| download | linux-crypto-93793f8fa3ab9cf3655a339357c295f870aa9622.tar.gz linux-crypto-93793f8fa3ab9cf3655a339357c295f870aa9622.zip | |
crypto: rsa-pkcs1pad - fix buffer overread in pkcs1pad_verify_complete()
Before checking whether the expected digest_info is present, we need to
check that there are enough bytes remaining.
Fixes: 39669c60ba49 ("crypto: Add hash param to pkcs1pad")
Cc: <stable@vger.kernel.org> # v4.6+
Cc: Tadeusz Struk <tadeusz.struk@linaro.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/rsa-pkcs1pad.c')
| -rw-r--r-- | crypto/rsa-pkcs1pad.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/crypto/rsa-pkcs1pad.c b/crypto/rsa-pkcs1pad.c index 6b556dde..9d804831 100644 --- a/crypto/rsa-pkcs1pad.c +++ b/crypto/rsa-pkcs1pad.c @@ -476,6 +476,8 @@ static int pkcs1pad_verify_complete(struct akcipher_request *req, int err) pos++; if (digest_info) { + if (digest_info->size > dst_len - pos) + goto done; if (crypto_memneq(out_buf + pos, digest_info->data, digest_info->size)) goto done; |