aboutsummaryrefslogtreecommitdiff
path: root/device/noise-protocol.go
diff options
context:
space:
mode:
authorJosh Bleecher Snyder <josh@tailscale.com>2020-12-15 15:02:13 -0800
committerJosh Bleecher Snyder <josh@tailscale.com>2020-12-16 16:16:26 -0800
commit4bced36d327754ad9567eba450413c07ff80da72 (patch)
treec235b16ab7aae0907f4276feef66239eb820a29b /device/noise-protocol.go
parent7d88fbd2177caccef40ab60c927f9539e723903e (diff)
downloadwireguard-go-4bced36d327754ad9567eba450413c07ff80da72.tar.gz
wireguard-go-4bced36d327754ad9567eba450413c07ff80da72.zip
device: fix races from changing private_key
Access keypair.sendNonce atomically. Eliminate one unnecessary initialization to zero. Mutate handshake.lastSentHandshake with the mutex held. Co-authored-by: David Anderson <danderson@tailscale.com> Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
Diffstat (limited to 'device/noise-protocol.go')
-rw-r--r--device/noise-protocol.go1
1 files changed, 0 insertions, 1 deletions
diff --git a/device/noise-protocol.go b/device/noise-protocol.go
index 1dc854f..e34da83 100644
--- a/device/noise-protocol.go
+++ b/device/noise-protocol.go
@@ -566,7 +566,6 @@ func (peer *Peer) BeginSymmetricSession() error {
setZero(recvKey[:])
keypair.created = time.Now()
- keypair.sendNonce = 0
keypair.replayFilter.Reset()
keypair.isInitiator = isInitiator
keypair.localIndex = peer.handshake.localIndex