summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2021-02-22 17:25:46 +0100
committerJason A. Donenfeld <Jason@zx2c4.com>2022-07-07 13:26:43 +0200
commit6fa20a6c099528e5502fe53eaca79034047bc852 (patch)
tree7d2e6b6eaad91cfaaf56dac7caef4bf068f3d3c3
parent162db58803ae925c044640dbb0f19da1b20297a5 (diff)
downloadwireguard-linux-trimmed-6fa20a6c099528e5502fe53eaca79034047bc852.tar.gz
wireguard-linux-trimmed-6fa20a6c099528e5502fe53eaca79034047bc852.zip
wireguard: peer: put frequently used members above cache lines
commit 4a0e2188a72aa502fa7b338ff18b8b49ebe05e9d upstream. The is_dead boolean is checked for every single packet, while the internal_id member is used basically only for pr_debug messages. So it makes sense to hoist up is_dead into some space formerly unused by a struct hole, while demoting internal_api to below the lowest struct cache line. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
-rw-r--r--drivers/net/wireguard/peer.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireguard/peer.h b/drivers/net/wireguard/peer.h
index 23af409..aaff8de 100644
--- a/drivers/net/wireguard/peer.h
+++ b/drivers/net/wireguard/peer.h
@@ -39,6 +39,7 @@ struct wg_peer {
struct crypt_queue tx_queue, rx_queue;
struct sk_buff_head staged_packet_queue;
int serial_work_cpu;
+ bool is_dead;
struct noise_keypairs keypairs;
struct endpoint endpoint;
struct dst_cache endpoint_cache;
@@ -61,9 +62,8 @@ struct wg_peer {
struct rcu_head rcu;
struct list_head peer_list;
struct list_head allowedips_list;
- u64 internal_id;
struct napi_struct napi;
- bool is_dead;
+ u64 internal_id;
};
struct wg_peer *wg_peer_create(struct wg_device *wg,