diff options
author | David S. Miller <davem@davemloft.net> | 2020-08-18 12:28:45 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-08-18 12:28:45 -0700 |
commit | 58de2b5dc6e1acc0dfe15dfc5fb863c3aec47566 (patch) | |
tree | e918551026d7e005359f86aefd20f6107b7c3e82 /drivers/net/wireguard/peerlookup.c | |
parent | 7aa3076c843b5df47a067b103ceadabbb6fc8a3a (diff) | |
parent | 90fdb9112eef886f4efe213d17f80b030241216e (diff) | |
download | wireguard-linux-trimmed-58de2b5dc6e1acc0dfe15dfc5fb863c3aec47566.tar.gz wireguard-linux-trimmed-58de2b5dc6e1acc0dfe15dfc5fb863c3aec47566.zip |
Merge branch 'netlink-allow-NLA_BINARY-length-range-validation'
Johannes Berg says:
====================
netlink: allow NLA_BINARY length range validation
In quite a few places (perhaps particularly in wireless) we need to
validation an NLA_BINARY attribute with both a minimum and a maximum
length. Currently, we can do either of the two, but not both, given
that we have NLA_MIN_LEN (minimum length) and NLA_BINARY (maximum).
Extend the range mechanisms that we use for integer validation to
apply to NLA_BINARY as well.
After converting everything to use NLA_POLICY_MIN_LEN() we can thus
get rid of the NLA_MIN_LEN type since that's now a special case of
NLA_BINARY with a minimum length validation. Similarly, NLA_EXACT_LEN
can be specified using NLA_POLICY_EXACT_LEN() and also maps to the
new NLA_BINARY validation (min == max == desired length).
Finally, NLA_POLICY_EXACT_LEN_WARN() also gets to be a somewhat
special case of this.
I haven't included the patch here now that converts nl82011 to use
this because it doesn't apply without another cleanup patch, but
we can remove a number of hand-coded min/max length checks and get
better error messages from the general validation code while doing
that.
As I had originally built the netlink policy export to userspace in
a way that has min/max length for NLA_BINARY (for the types that we
used to call NLA_MIN_LEN, NLA_BINARY and NLA_EXACT_LEN) anyway, it
doesn't really change anything there except that now there's a chance
that userspace sees min length < max length, which previously wasn't
possible.
v2:
* fix the min<max comment to correctly say min<=max
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wireguard/peerlookup.c')
0 files changed, 0 insertions, 0 deletions