diff options
author | Jason A. Donenfeld <Jason@zx2c4.com> | 2020-01-08 16:59:02 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-01-08 15:19:54 -0800 |
commit | 0718f2eef6af314850dba3dcbf3cd5781507c083 (patch) | |
tree | 99e19cb2934d649e17029fb5c41cb7731e64a6f8 /drivers/net/wireguard/receive.c | |
parent | 620b15b8196a3a6d8632f4b03bb9a79eefab4c7c (diff) | |
download | wireguard-linux-trimmed-0718f2eef6af314850dba3dcbf3cd5781507c083.tar.gz wireguard-linux-trimmed-0718f2eef6af314850dba3dcbf3cd5781507c083.zip |
net: introduce skb_list_walk_safe for skb segment walking
As part of the continual effort to remove direct usage of skb->next and
skb->prev, this patch adds a helper for iterating through the
singly-linked variant of skb lists, which are used for lists of GSO
packet. The name "skb_list_..." has been chosen to match the existing
function, "kfree_skb_list, which also operates on these singly-linked
lists, and the "..._walk_safe" part is the same idiom as elsewhere in
the kernel.
This patch removes the helper from wireguard and puts it into
linux/skbuff.h, while making it a bit more robust for general usage. In
particular, parenthesis are added around the macro argument usage, and it
now accounts for trying to iterate through an already-null skb pointer,
which will simply run the iteration zero times. This latter enhancement
means it can be used to replace both do { ... } while and while (...)
open-coded idioms.
This should take care of these three possible usages, which match all
current methods of iterations.
skb_list_walk_safe(segs, skb, next) { ... }
skb_list_walk_safe(skb, skb, next) { ... }
skb_list_walk_safe(segs, skb, segs) { ... }
Gcc appears to generate efficient code for each of these.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions