diff options
author | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-09-16 15:37:40 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-09-20 11:26:14 -0700 |
commit | e5e55ba7f751e3eabdff34d59d90cd00052fb1e0 (patch) | |
tree | 9b0b8c765ffec425833948f57b3c3de483994952 /drivers/net/wireguard/version.h | |
parent | 64d185003e6f35aa0f08960c9f0d14d83368c54a (diff) | |
download | wireguard-linux-trimmed-e5e55ba7f751e3eabdff34d59d90cd00052fb1e0.tar.gz wireguard-linux-trimmed-e5e55ba7f751e3eabdff34d59d90cd00052fb1e0.zip |
wireguard: netlink: avoid variable-sized memcpy on sockaddr
Doing a variable-sized memcpy is slower, and the compiler isn't smart
enough to turn this into a constant-size assignment.
Further, Kees' latest fortified memcpy will actually bark, because the
destination pointer is type sockaddr, not explicitly sockaddr_in or
sockaddr_in6, so it thinks there's an overflow:
memcpy: detected field-spanning write (size 28) of single field
"&endpoint.addr" at drivers/net/wireguard/netlink.c:446 (size 16)
Fix this by just assigning by using explicit casts for each checked
case.
Fixes: a8f1bc7bdea3 ("net: WireGuard secure network tunnel")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reported-by: syzbot+a448cda4dba2dac50de5@syzkaller.appspotmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/wireguard/version.h')
0 files changed, 0 insertions, 0 deletions