diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2020-03-18 18:30:46 -0600 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-07-07 13:26:41 +0200 |
| commit | 2ce900eab755e875a6b66162a12611cefe0592b3 (patch) | |
| tree | 73d125290a660f1576a45fbe1d1a8f8973a4c08f /drivers | |
| parent | 94c5d5ba2ad2332167a912894788fa4f5d49d513 (diff) | |
| download | wireguard-linux-trimmed-2ce900eab755e875a6b66162a12611cefe0592b3.tar.gz wireguard-linux-trimmed-2ce900eab755e875a6b66162a12611cefe0592b3.zip | |
wireguard: receive: remove dead code from default packet type case
commit b3ab061a424b6e0639b0b09b147cad3083c53adb upstream.
The situation in which we wind up hitting the default case here
indicates a major bug in earlier parsing code. It is not a usual thing
that should ever happen, which means a "friendly" message for it doesn't
make sense. Rather, replace this with a WARN_ON, just like we do earlier
in the file for a similar situation, so that somebody sends us a bug
report and we can fix it.
Reported-by: Fabian Freyer <fabianfreyer@radicallyopensecurity.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/wireguard/receive.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireguard/receive.c b/drivers/net/wireguard/receive.c index 243ed71..da3b782 100644 --- a/drivers/net/wireguard/receive.c +++ b/drivers/net/wireguard/receive.c @@ -587,8 +587,7 @@ void wg_packet_receive(struct wg_device *wg, struct sk_buff *skb) wg_packet_consume_data(wg, skb); break; default: - net_dbg_skb_ratelimited("%s: Invalid packet from %pISpfsc\n", - wg->dev->name, skb); + WARN(1, "Non-exhaustive parsing of packet header lead to unknown packet type!\n"); goto err; } return; |