diff options
| author | Loïc Blot <loic.blot@unix-experience.fr> | 2019-01-04 10:20:04 +0100 |
|---|---|---|
| committer | Loïc Blot <loic.blot@unix-experience.fr> | 2019-01-04 10:20:04 +0100 |
| commit | c1d7dbfc38e8f48b42d957afad2696a8e56b740b (patch) | |
| tree | 53db583fc199c9eb096c15e6ffa6c85539a54c0d /src/database/database-sqlite3.cpp | |
| parent | 07177190734b0e5c17be18d0bf5d509c5226af2f (diff) | |
| download | hax-minetest-server-c1d7dbfc38e8f48b42d957afad2696a8e56b740b.tar.gz hax-minetest-server-c1d7dbfc38e8f48b42d957afad2696a8e56b740b.zip | |
Fix various player save issues (performance penalty on sql backends + bugs)
* PostgreSQL & SQLite3 doesn't setModified(false) on RemotePlayer, then player is saved on each server save call. This results in heavy useless writes.
* PostgreSQL & SQLite3 ack engine meta write whereas db commit hasn't been performed. If commit failed write has failed. We mustn't notify engine write is done.
* serializing player meta must not setModified(false) because it didn't ensure write has been done
* add RemotePlayer::on_successfull_save callback to do the flag update on a successful save
Diffstat (limited to 'src/database/database-sqlite3.cpp')
| -rw-r--r-- | src/database/database-sqlite3.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/database/database-sqlite3.cpp b/src/database/database-sqlite3.cpp index aa156bbbd..7a79fb187 100644 --- a/src/database/database-sqlite3.cpp +++ b/src/database/database-sqlite3.cpp @@ -528,9 +528,10 @@ void PlayerDatabaseSQLite3::savePlayer(RemotePlayer *player) sqlite3_vrfy(sqlite3_step(m_stmt_player_metadata_add), SQLITE_DONE); sqlite3_reset(m_stmt_player_metadata_add); } - sao->getMeta().setModified(false); endSave(); + + player->on_successful_save(); } bool PlayerDatabaseSQLite3::loadPlayer(RemotePlayer *player, PlayerSAO *sao) |