summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2016-12-13 09:26:18 +0000
committerHerbert Xu <herbert@gondor.apana.org.au>2016-12-14 18:33:13 +0800
commit40c5e23eb6608e193908aa56f4dd807a54537987 (patch)
tree1c1e70f0b141491ca843b82a2ba098a597a3d156
parent7dd8ae8e3b16f2f9581f4208bbc853f41f1820df (diff)
downloadlinux-crypto-40c5e23eb6608e193908aa56f4dd807a54537987.tar.gz
linux-crypto-40c5e23eb6608e193908aa56f4dd807a54537987.zip
crypto: asymmetric_keys - set error code on failure
In function public_key_verify_signature(), returns variable ret on error paths. When the call to kmalloc() fails, the value of ret is 0, and it is not set to an errno before returning. This patch fixes the bug. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891 Signed-off-by: Pan Bian <bianpan2016@163.com> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--crypto/asymmetric_keys/public_key.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
index fd76b5fc..d3a989e7 100644
--- a/crypto/asymmetric_keys/public_key.c
+++ b/crypto/asymmetric_keys/public_key.c
@@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
if (ret)
goto error_free_req;
+ ret = -ENOMEM;
outlen = crypto_akcipher_maxsize(tfm);
output = kmalloc(outlen, GFP_KERNEL);
if (!output)