diff options
| author | Eric Biggers <ebiggers@google.com> | 2017-12-08 15:13:29 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2017-12-08 15:13:29 +0000 |
| commit | 8dce1988dfaa3668372990f05ee2202d9d9521b5 (patch) | |
| tree | 149f57c9ce794734883e326d63040b1381dc1a59 /crypto/asymmetric_keys/x509_public_key.c | |
| parent | 46eec7256a769678fc3b05803c60dd22e65e153f (diff) | |
| download | linux-crypto-8dce1988dfaa3668372990f05ee2202d9d9521b5.tar.gz linux-crypto-8dce1988dfaa3668372990f05ee2202d9d9521b5.zip | |
X.509: fix comparisons of ->pkey_algo
->pkey_algo used to be an enum, but was changed to a string by commit
4a2d8af15954 ("X.509: Make algo identifiers text instead of enum"). But
two comparisons were not updated. Fix them to use strcmp().
This bug broke signature verification in certain configurations,
depending on whether the string constants were deduplicated or not.
Fixes: 4a2d8af15954 ("X.509: Make algo identifiers text instead of enum")
Cc: <stable@vger.kernel.org> # v4.6+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'crypto/asymmetric_keys/x509_public_key.c')
| -rw-r--r-- | crypto/asymmetric_keys/x509_public_key.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/asymmetric_keys/x509_public_key.c b/crypto/asymmetric_keys/x509_public_key.c index e67fd29f..9338b455 100644 --- a/crypto/asymmetric_keys/x509_public_key.c +++ b/crypto/asymmetric_keys/x509_public_key.c @@ -131,7 +131,7 @@ int x509_check_for_self_signed(struct x509_certificate *cert) } ret = -EKEYREJECTED; - if (cert->pub->pkey_algo != cert->sig->pkey_algo) + if (strcmp(cert->pub->pkey_algo, cert->sig->pkey_algo) != 0) goto out; ret = public_key_verify_signature(cert->pub, cert->sig); |