diff options
| author | David Howells <dhowells@redhat.com> | 2023-07-07 10:12:38 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2023-07-08 22:48:42 +1000 |
| commit | e8105153ef8ad9dd393d6fcbc6a4b72ab696e4b1 (patch) | |
| tree | 182c053cd6cf5582bad3a673ad6475960d93acb5 /crypto/geniv.c | |
| parent | afe6cbed113283af5f268696f526f864cb103a70 (diff) | |
| download | linux-crypto-e8105153ef8ad9dd393d6fcbc6a4b72ab696e4b1.tar.gz linux-crypto-e8105153ef8ad9dd393d6fcbc6a4b72ab696e4b1.zip | |
crypto: algif_hash - Fix race between MORE and non-MORE sends
The 'MSG_MORE' state of the previous sendmsg() is fetched without the
socket lock held, so two sendmsg calls can race. This can be seen with a
large sendfile() as that now does a series of sendmsg() calls, and if a
write() comes in on the same socket at an inopportune time, it can flip the
state.
Fix this by moving the fetch of ctx->more inside the socket lock.
Fixes: 7fccb620a7e9 ("crypto: af_alg/hash: Support MSG_SPLICE_PAGES")
Reported-by: syzbot+689ec3afb1ef07b766b2@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/000000000000554b8205ffdea64e@google.com/
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: syzbot+689ec3afb1ef07b766b2@syzkaller.appspotmail.com
cc: Herbert Xu <herbert@gondor.apana.org.au>
cc: Paolo Abeni <pabeni@redhat.com>
cc: "David S. Miller" <davem@davemloft.net>
cc: Eric Dumazet <edumazet@google.com>
cc: Jakub Kicinski <kuba@kernel.org>
cc: linux-crypto@vger.kernel.org
cc: netdev@vger.kernel.org
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/geniv.c')
0 files changed, 0 insertions, 0 deletions