diff options
| author | Eric Biggers <ebiggers@google.com> | 2019-01-03 20:16:13 -0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-01-11 14:16:57 +0800 |
| commit | 0e662582cd48f44555eb97e361616f3399ce12db (patch) | |
| tree | 8dea319e53b16ab741aa09f07ac3b65627fc6f9d /crypto/skcipher.c | |
| parent | 563344438270aa0743c7b9bc0b55618dd21f8be7 (diff) | |
| download | linux-crypto-0e662582cd48f44555eb97e361616f3399ce12db.tar.gz linux-crypto-0e662582cd48f44555eb97e361616f3399ce12db.zip | |
crypto: pcbc - remove bogus memcpy()s with src == dest
The memcpy()s in the PCBC implementation use walk->iv as both the source
and destination, which has undefined behavior. These memcpy()'s are
actually unneeded, because walk->iv is already used to hold the previous
plaintext block XOR'd with the previous ciphertext block. Thus,
walk->iv is already updated to its final value.
So remove the broken and unnecessary memcpy()s.
Fixes: 4d2e26013333 ("[CRYPTO] pcbc: Add Propagated CBC template")
Cc: <stable@vger.kernel.org> # v2.6.21+
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/skcipher.c')
0 files changed, 0 insertions, 0 deletions